D29272: Add support to keyboard shortcuts inhibitor

[David Edmundson]

davidedmundson added a comment.


    "The Wayland compositor is however under no obligation to disable
     all of its shortcuts, and may keep some special key combo for its own
     use, including but not limited to one allowing the user to forcibly
     restore normal keyboard events routing in the case of an unwilling
     client. The compositor may also use the same key combo to reactivate
     an existing shortcut inhibitor that was previously deactivated on
     user request."
  
  Do we think it's important to have this when this lands or just deal with it if it becomes an issue?
  
  I think it should be relatively easy, just an earlier filter that calls:
  waylandServer()->keyboardShortcutsInhibitManager()->getShortcutsInhibitor(surface, seat)->setActive(false);

INLINE COMMENTS

> input.cpp:792
> +            auto seat = waylandServer()->seat();
> +            auto surface = seat->focusedKeyboardSurface();
> +            auto inhibitor = waylandServer()->keyboardShortcutsInhibitManager()->getShortcutsInhibitor(surface, seat);

Surface can be null

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29272

To: bport, davidedmundson, zzag
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200429/4f79b924/attachment-0001.html>