D29180: [kwinrules] Avoid shadowing FINAL property

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In Qt5.15 currentValue is a FINAL property meaning that shadowing it is
  a fatal eror.
  
  Also this patch slightly more gracefully handles QML errors. Asserting
  instead of crash.

TEST PLAN
  Used against Qt5.15 git compiled qqc2-desktop-style

REPOSITORY
  R108 KWin

BRANCH
  davidedmundson/wl_temp

REVISION DETAIL
  https://phabricator.kde.org/D29180

AFFECTED FILES
  kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml
  kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml
  kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml
  kcmkwin/kwinrules/rulesdialog.cpp

To: davidedmundson, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200425/67ad688a/attachment.html>