D29122: ScreenShotEffect: Add a shouldReturnNativeSize argument to screenshotFullscreen

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> screenshot.cpp:198
> +    QMap<ComparableQPoint, ComparableQPoint> translationMap;
> +    for (const auto point: m_cacheOutputsImages.keys()) {
> +        translationMap.insert(point, point);

Don't iterate `keys()`. Use iterators.

> screenshot.cpp:207
> +        const auto dpr = img.devicePixelRatio();
> +        if (dpr != 1.0) {
> +            // must update all coordinates of next rects

`qFuzzyCompare`

> screenshot.cpp:214
> +            // thanks to ComparableQPoint
> +            QMap<ComparableQPoint, QImage>::iterator i3 = m_cacheOutputsImages.find(i2.key());
> +            while (i3 != m_cacheOutputsImages.end()) {

`auto`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29122

To: meven, #kwin, davidedmundson, bport, zzag, apol
Cc: broulik, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200423/634c803c/attachment-0001.html>