D27862: KCM KWinTouchScreen port to KConfigXT

Kevin Ottens noreply at phabricator.kde.org
Wed Apr 22 21:42:26 BST 2020


ervin added inline comments.

INLINE COMMENTS

> kwinscreenedge.cpp:165
> +    default: // ELECTRIC_COUNT and ElectricNone
> +        Q_ASSERT(false);
> +    }

Ah indeed, in non-debug builds Q_ASSERT is a noop so you still need to return something after it. Also now I realize that using Q_UNREACHABLE would have probably been better too.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27862

To: crossi, #kwin, ervin, bport, meven, zzag
Cc: ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200422/d2058c78/attachment.html>


More information about the kwin mailing list