D28708: egl: encapsulate and share duplicated code

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Looks fine to me, please address my inline comments before landing this patch.

INLINE COMMENTS

> abstract_egl_backend.cpp:477-480
>      glGenTextures(1, &m_texture);
> -    q->setWrapMode(GL_CLAMP_TO_EDGE);
>      q->setFilter(GL_LINEAR);
> -    q->bind();

Unnecessary shuffling of lines.

> abstract_egl_backend.cpp:510-514
> -
>      q->unbind();
> -    q->setYInverted(true);
> +
>      m_size = size;
>      updateMatrix();

Unnecessary shuffling of lines. Please undo it.

REPOSITORY
  R108 KWin

BRANCH
  refactors3

REVISION DETAIL
  https://phabricator.kde.org/D28708

To: apol, #kwin, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200422/42ce1276/attachment.html>