D28889: Avoid crash in KWin::DrmOutput::updateCursor

Vlad Zahorodnii noreply at phabricator.kde.org
Fri Apr 17 08:38:00 BST 2020


zzag added inline comments.

INLINE COMMENTS

> meven wrote in drm_output.cpp:90
> I replace those deletes, as they did not delete the m_cursor array and allowed m_cursor[i] to keep dangling pointers causing down the line crash in QImage rather than a proper segfault where m_cursor[i] was used.

m_cursor is not a dynamically allocated array. We should not `delete[]` it.

REPOSITORY
  R108 KWin

BRANCH
  arcpatch-D28889

REVISION DETAIL
  https://phabricator.kde.org/D28889

To: meven, #kwin, zzag, davidedmundson
Cc: ngraham, apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200417/f5ae98ee/attachment.html>


More information about the kwin mailing list