D28152: KWinRules KCM Redesign

[Ismael Asensio]

iasensio added inline comments.

INLINE COMMENTS

> ngraham wrote in RuleItemDelegate.qml:43
> Same here; would be nice if clicking on the icon or text also activated the checkbox.

I'm not so sure here. Since this is a complex item, I find toggling selection on text click unexpected, and any misclick can be confusing. Deselecting will hide the item (it's like removing it from the list), and only activating on click would be very inconsistent.
So I'd rather keep the selection action here to the checkbox.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28152

To: iasensio, #plasma, #kwin, #vdg
Cc: ngraham, davidedmundson, hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200417/ce432b26/attachment.html>