D28889: Avoid crash in KWin::DrmOutput::updateCursor

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I think part is superfluous, but the rest makes sense.

INLINE COMMENTS

> drm_output.cpp:85-88
> +        if (m_backend->deleteBufferAfterPageFlip()) {
> +            delete m_cursorPlane->current();
> +        }
> +        m_cursorPlane->setCurrent(nullptr);

From what I can tell we never call m_cursorPlane->setCurrent with anything non-null? So this is all a no-op.

The buffers are the m_cursor buffers deleted below, and they're set directly below.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28889

To: meven, #kwin, zzag, davidedmundson
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200416/af47d075/attachment.html>