D28885: Avoid deleting BlueInterface global
David Edmundson
noreply at phabricator.kde.org
Thu Apr 16 16:00:28 BST 2020
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.
REVISION SUMMARY
If a global is deleted whilst a client is trying to bind, the wayland
server will still dispatch the event - there will be no object to
dispatch to and the client will be killed.
Effects are torn down and recreated at runtime. Often in quick
succession which makes this easy to hit.
The use of a static isn't ideal but it's keeps the encapsulation.
BUG: 419912
TEST PLAN
Changed fonts, plasma didn't crash
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28885
AFFECTED FILES
effects/blur/blur.cpp
effects/blur/blur.h
To: davidedmundson, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200416/20f84eff/attachment-0001.html>
More information about the kwin
mailing list