D28674: Implement a updateXTime compatible with Xcb and XWayland

[Vlad Zahorodnii]

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> zzag wrote in CMakeLists.txt:512
> Rename the class to SyncAlarmNotifyX11Filter or something.

Please keep filenames in alphabetical order. Tip: open vim, select relevant lines in the visual mode, and run the `sort` command.

> platform.cpp:38
> +#include "xcb/xproto.h"
> +#include "atoms.h"
> +

This include must come after `#include "abstract_output.h"`

> platform.h:44
>  {
> +
>  namespace ColorCorrect {

Unrelated change, please remove it.

> workspace.cpp:453-455
> +            if (Xcb::Extensions::self()->isSyncAvailable()) {
> +                m_syncFilter = std::make_unique<SyncAlarmNotifyX11Filter>();
> +            }

This `if` must be in `initWithX11`.

> workspace.h:674
>      SessionManager *m_sessionManager;
> +    std::unique_ptr<SyncAlarmNotifyX11Filter> m_syncFilter;
>  private:

I know that QScopedPointer sucks, but I suggest to use it anyway for the consistency sake.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28674

To: meven, #kwin, davidedmundson, zzag
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200414/fa5d7085/attachment.html>