D28668: [wayland] Fix teardown order

David Edmundson noreply at phabricator.kde.org
Tue Apr 7 22:36:24 BST 2020


davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Valgrind flags an error on teardown.
  
  EventQueue has a pointer to ConnectionThread internally
  Registry has a pointer to the EventQueue internally
  
  teardown order needs to be
  
  Registry
  EventQueue
  Connection
  
  registry was explicitly deleted before connectionthread already, we just
  need to put event queue in the right place.

TEST PLAN
  Ran kwin_wayland nested in valgrind

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28668

AFFECTED FILES
  wayland_server.cpp

To: davidedmundson, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200407/923cb549/attachment.html>


More information about the kwin mailing list