D27862: KCM KWinTouchScreen port to KConfigXT

Kevin Ottens noreply at phabricator.kde.org
Tue Apr 7 16:51:22 BST 2020


ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Two little things.

INLINE COMMENTS

> kwinscreenedge.cpp:35
> +
> +KWin::KWinScreenEdge::~KWinScreenEdge()
> +{

That KWin namespace is redundant here.

> kwinscreenedge.cpp:77
> +{
> +    QList<int> list = QList<int>();
> +    if (monitor()->selectedEdgeItem(Monitor::Top) == index) {

Either:
`auto list = QList<int>();`
or
`QList<int> list;`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27862

To: crossi, #kwin, ervin, bport, meven, zzag
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200407/19a5e6cf/attachment.html>


More information about the kwin mailing list