D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding

Cyril Rossi noreply at phabricator.kde.org
Mon Apr 6 14:52:54 BST 2020


crossi added a comment.


  F8220782: Screenshot_20200406_153118e.png <https://phabricator.kde.org/F8220782>
  
  F8220781: Screenshot_20200406_154236e.png <https://phabricator.kde.org/F8220781>
  
  The indicators are not well placed.

INLINE COMMENTS

> main.qml:81
>                          Layout.fillHeight: true
> -                        enabled: !kcm.settings.isImmutable("pluginName") && !kcm.settings.isImmutable("theme")
>                      }

Both entries are set when changing the decoration.
Consider both are immutable but need to check one to disable the Themes grid.

> main.qml:133
>                          Layout.fillHeight: true
> -                        enabled: !kcm.settings.isImmutable("buttonsOnLeft") && !kcm.settings.isImmutable("buttonsOnRight")
>                      }

Does it make sense to disable only one side for editing the list of buttons in the windows titlebar ?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28622

To: crossi, ervin, bport, meven
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200406/f2d12e53/attachment-0001.html>


More information about the kwin mailing list