D24112: [platforms/drm] Disable setting 90° transformations

[Bhushan Shah]

bshah added a comment.


  In D24112#538658 <https://phabricator.kde.org/D24112#538658>, @romangg wrote:
  
  > Thanks for looking into this. But I don't think there is a (good) solution possible without some principle changes. For example wayland output device transformation is set in the Drm backend but should be set on AbstractWaylandOutput level.
  >
  > Overall I want to have the following structure:
  
  
  Planned changes look good to me, but I am trying to understand why current code is failing the way it is failing (even if we don't fix this in end is fine. but as a learning exercise I am trying to fix this)
  
  I've some questions and more debug information, if you want to answer them.
  
  When looking at this further, our atomic commit fails with `ENOSPC`, and looking at dmesg, I found following,
  
    [  132.351603] [drm:drm_atomic_check_only [drm]] [PLANE:30:plane 1A] invalid source coordinates 1920.000000x1080.000000+0.000000+0.000000 (fb 1080x1920)
  
  So basically we are trying to fit a 1920x1080 source in 1080x1920. Do I understand this correctly one should also adjust the values of src_x, src_y in addition to just transformation property as we are doing here?
  
    void DrmPlane::setTransformation(Transformations t)
    {
        if (auto property = m_props.at(int(PropertyIndex::Rotation))) {
            property->setValue(int(t));
        }
    }
  
  I found some code in the weston, https://gitlab.freedesktop.org/wayland/weston/blob/master/libweston/backend-drm/state-helpers.c#L165 which does something to that effect, are we missing this code in kwin? or I am missing something else? 😛

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24112

To: romangg, #kwin
Cc: bshah, zzag, apol, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190927/2fb928ea/attachment-0001.html>