D24084: Migrate kwin animation speed to kdeglobals

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kwin-5.18-move-animspeed.py:1
> It does not need python2. 
> It's written and tested against python3.
> 
> My understanding was that /bin/env was the "correct" way to choose python in weird distros.
> 
> I ideally want to avoid having some cmake stuff and then reconfiguring this script. If hardcoding /usr/bin/python3 works for distros, that's more than fine with me.

> My understanding was that /bin/env was the "correct" way to choose python in weird distros.

With /usr/bin/env yes, but what "python" means depends on the distro. For some it doesn't exist, for some it's py2 and for some it's py3...
Also see https://www.python.org/dev/peps/pep-0394/#for-python-script-publishers.

> If hardcoding /usr/bin/python3 works for distros, that's more than fine with me.

I can't think of a situation where this would fail. `/usr/bin/env python3` maybe if someone wants to use python3 from /usr/local or ~/bin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24084

To: davidedmundson, zzag
Cc: lbeltrame, fvogt, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190927/5aa182db/attachment-0001.html>