D24244: Use lambdas for queued invocation of composition suspending

David Edmundson noreply at phabricator.kde.org
Thu Sep 26 16:08:49 BST 2019


davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in composite.cpp:1017-1019
> It'll be more compact with QTimer::singleShot.
> 
>   QTimer::singleShot(0, this, [this]() { suspend(BlockRuleSuspend); });
> 
> I don't have strong opinion about this though.

Yeah, I typically use QTimer out of habit, though I've seen comments saying to use QMetaObject for semantic reasons.

They end up being exactly the same thing, I don't think either is better or worse.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24244

To: davidedmundson, #kwin, zzag
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190926/41b76409/attachment-0001.html>


More information about the kwin mailing list