D24244: Use lambdas for queued invocation of composition suspending

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Qt's metaobject is rather sensitive with scope resolution.
  
  Foo::Bar and Bar don't always match to a Qt metaobject, even if they
  refer to the same thing to a compiler. Here we register
  X11Compositor::SuspendReason but Q_ARG uses SuspendReason and they don't
  match. This leads to a runtime failure where the method isn't invoked.
  
  Rather than fixing metaobject usage, port the whole thing to lambdas
  which does better compile time checking and is generally nicer to read.
  
  BUG: 412353

TEST PLAN
  Ran xprop to block compositing. Compositing was blocked.
  Grepped source code for Q_ARG use

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24244

AFFECTED FILES
  composite.cpp
  composite.h
  plugins/scenes/opengl/scene_opengl.cpp

To: davidedmundson, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190926/1ece7277/attachment-0001.html>