D24153: [nightcolor] Use local time in Automatic and Location mode

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  From feedback t does not fix the bug fully but conceptually it makes sense I think. Maybe add a comment that all times are in local timezone from now on.

INLINE COMMENTS

> suncalc.cpp:157
> +    if (!std::isnan(begin)) {
> +        const double fraction = begin - int(begin);
> +        const QTime utcTime = QTime::fromMSecsSinceStartOfDay(fraction * MSC_DAY);

Why call this variable fraction now what is less descriptive about what it represents?

> suncalc.cpp:164
> +    if (!std::isnan(end)) {
> +        const double fraction = end - int(end);
> +        const QTime utcTime = QTime::fromMSecsSinceStartOfDay(fraction * MSC_DAY);

Here as well.

REPOSITORY
  R108 KWin

BRANCH
  fix-colorcorrect

REVISION DETAIL
  https://phabricator.kde.org/D24153

To: zzag, #kwin, romangg
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190925/0073d804/attachment-0001.html>