D24207: Avoid event processing infinite loop

David Edmundson noreply at phabricator.kde.org
Tue Sep 24 22:48:16 BST 2019


davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Kwin on X11 overrides QCoreApplication::notify to get low level system
  event.
  
  If something handled by the low level filtering ever calls postEvent we
  would end up in a loop. This was found when forwarding a key event into
  a QQuickWindow in a similar manner that mouse events are forwarded.
  
  Fortunately there's a flag to separate generated and core events

TEST PLAN
  No more infinite loop
  Kwin X11 still works fine

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24207

AFFECTED FILES
  main_x11.cpp

To: davidedmundson, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190924/a12d5e3e/attachment.html>


More information about the kwin mailing list