D23589: Rename ShellClient to XdgShellClient

[Vlad Zahorodnii]

zzag added a comment.


  In D23589#536285 <https://phabricator.kde.org/D23589#536285>, @romangg wrote:
  
  > I don't have a strong opinion about that but I feel we could leave the `ShellClient` name since it's shorter and there is no ambiguity anyway when there are only xdg-shell clients. One could add a comment to the class that these instances represent xdg-shell clients.
  
  
  It seems like you want to leave a room for other protocols in ShellClient class, however as far as I can tell you keeping wl-shell and xdg-shell in one class (ShellClient) was a bad idea. "Fixing" xdg-shell could easily break wl-shell and complexity of the code was a bit high.
  
  Given that you don't have a strong opinion on this one, I'll land this patch as is.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23589

To: zzag, #kwin
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190923/4d2423f7/attachment-0001.html>