D22810: Port QPA away from Wayland

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in workspace.h:652
> If it's really that important to keep Workspace class `friend`-free, I can make those two methods public. However, it'll pollute public interface of Workspace class.

For example, X11EventFilter does something similar to what InternalClient does. It registers itself in a constructor and unregisters itself in the destructor.

  void registerEventFilter(X11EventFilter *filter);

implies that one create X11EventFilter object on the heap, initialize it, and after that call registerEventFilter method. However, that's absolutely not true. Such implementation details have to be hidden.

`friend` keyword is not a good thing, I don't deny it. However, in some cases it's a necessary measure to keep public stuff clean.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22810

To: zzag, #kwin, davidedmundson
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190923/dc1476fa/attachment-0001.html>