D22810: Port QPA away from Wayland

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in effects.cpp:1096
> On X is this not needed anymore? I.e. on X all internal clients now also are of type `InternalClient` and not anymore `Unmanaged`? If so, this needs to be mentioned in the commit message.

We don't need to call findUnmanaged as findInternal covers internal clients in X11 operation mode.

> romangg wrote in scene_qpainter.cpp:406
> Why can't it be an X client?

Are you talking about the case when a Client doesn't have a surface assigned to it yet?

> romangg wrote in workspace.h:652
> Is this really necessary?

I don't see any good reason to keep addInternalClient and removeInternalClient public.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22810

To: zzag, #kwin, davidedmundson
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190923/3999fe30/attachment.html>