D24075: [kcmkwin/compositing] Hide animation speed slider on Plasma

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Sep 19 16:50:57 BST 2019


zzag added inline comments.

INLINE COMMENTS

> compositing.cpp:378
>  
> +bool Compositing::isRunningPlasma() {
> +    return qgetenv("XDG_CURRENT_DESKTOP") == "KDE";

Style: `{` goes on the next line.

> main.cpp:33
>  
> +#include <math.h>
> +#include <functional>

Where is it used?

> main.cpp:34-35
> +#include <math.h>
> +#include <functional>
> +#include <algorithm>
> +

Keep them sorted alphabetically please.

> main.cpp:90
> +    m_form.animationSpeed->setMaximum(s_animationMultipliers.size() - 1);
> +    qDebug() << m_form.animationSpeed->minimum() << m_form.animationSpeed->maximum();
> +    auto setSpeed = [this](const qreal multiplier) {

Delete qDebug.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24075

To: davidedmundson
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190919/ad8c19ab/attachment.html>


More information about the kwin mailing list