D24084: Migrate kwin animation speed to kdeglobals

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Sep 19 16:41:55 BST 2019


zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kwin-5.18-move-animspeed.py:5
> +
> +speedMap = [0, 0.25, 0.5, 1, 2, 4, 20]
> +

Naming nitpick: speed_map

> kwin-5.18-move-animspeed.py:13-14
> +        continue
> +    print ("AnimationDurationFactor=%f" % speedMap[speed])
> +    print ("# DELETE AnimationSpeed") #special kconf syntax to remove the old key

A Python 2 developer detected. No whitespace between `print` and `(`.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24084

To: davidedmundson, zzag
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190919/6a840ade/attachment-0001.html>


More information about the kwin mailing list