D18000: Modernize easing function of slidingpopups effect.

Vlad Zahorodnii noreply at phabricator.kde.org
Sun Sep 15 22:38:26 BST 2019


zzag added a comment.


  So, I've been running your patch for a while and have to admit that disappearing animation looks better. However, I advise you and #vdg <https://phabricator.kde.org/tag/vdg/> to analyze (perhaps update hig as well?) our choice of easing curves in default effects, e.g. morphing popups, sliding popups, fade, etc, and based on that pick better curves.

INLINE COMMENTS

> slidingpopups.cpp:140-146
> +        slideLength = qMin(geo.width(), slideLength);
> +
>          if (slideLength < geo.width()) {
> -            data.multiplyOpacity(t);
> +            data.multiplyOpacity(interpolate(0.0, 1.0, t));
>          }
> -        data.translate(-interpolate(qMin(geo.width(), slideLength), 0.0, t));
> +
> +        data.translate(-interpolate(slideLength, 0.0, t));

Unrelated change.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18000

To: sefaeyeoglu, #vdg, zzag, #kwin
Cc: ngraham, abetts, davidedmundson, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190915/89d94822/attachment.html>


More information about the kwin mailing list