D23909: Pass area by const reference to placeFoo methods

Frederik Gladhorn noreply at phabricator.kde.org
Sat Sep 14 21:28:08 BST 2019


gladhorn added inline comments.

INLINE COMMENTS

> manage.cpp:408-409
>          Placement::self()->place(this, area);
> +        // The client may have been moved to another screen, update placement area.
> +        area = workspace()->clientArea(PlacementArea, this);
>          dontKeepInArea = true;

This looks like it does more than the commit message says. Is it fixing something? Then it should maybe be an independent commit.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23909

To: zzag, #kwin
Cc: gladhorn, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190914/c2012dbf/attachment.html>


More information about the kwin mailing list