D23918: RFC: Drop Outputs class

[Frederik Gladhorn]

gladhorn added inline comments.

INLINE COMMENTS

> platform.h:411
>      // outputs with connections (org_kde_kwin_outputdevice)
> -    virtual Outputs outputs() const {
> -        return Outputs();
> -    }
> +    virtual QVector<AbstractOutput *> outputs() const;
>      // actively compositing outputs (wl_output)

This could even be non-virtual in my suggestion:

  QVector<Output *> outputs() const { return m_outputs; }

> platform.h:552
>      CompositingType m_selectedCompositor = NoCompositing;
>  };
>  

QVector<Output*> m_outputs;

> drm_backend.h:83-84
>      }
> -    Outputs outputs() const override;
> -    Outputs enabledOutputs() const override;
> +    QVector<AbstractOutput *> outputs() const override;
> +    QVector<AbstractOutput *> enabledOutputs() const override;
>      QVector<DrmOutput*> drmOutputs() const {

This would simply go away, the base class version is enough.

> wayland_backend.cpp:352-353
>  {
>      auto outputIt = std::find_if(m_outputs.begin(), m_outputs.end(), [this](WaylandOutput *wo) {
>              return wo->surface() == m_seat->pointer()->enteredSurface();
>      });

Here a cast from Output* to WaylandOutput* would be needed.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23918

To: zzag, #kwin
Cc: gladhorn, anthonyfieroni, romangg, davidedmundson, alexeymin, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190914/65068d58/attachment-0001.html>