D23918: RFC: Drop Outputs class

[Frederik Gladhorn]

gladhorn added a comment.


  In general I agree with @zzag - composition is better than inheritance since it decouples things.
  Many modern programming languages don't even really allow inheritance any more at all.
  I wonder if there isn't a solution that avoids all the casting, I cannot say that I'm a fan of the qvector_cast. I didn't really read the code though, just glanced over it.

INLINE COMMENTS

> zzag wrote in utils.h:237
> Is it okay to use "qvector_cast" name?

Technically Qt reserves itself the right to qsomething_functions. A name clash is unlikely, but I would have expected the function to be part of Qt when reading the code without having any background. In that sense I'd be for a kvector_cast (not really, I don't have a good name and don't like the cast much).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23918

To: zzag, #kwin
Cc: gladhorn, anthonyfieroni, romangg, davidedmundson, alexeymin, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190914/bf5db5d4/attachment-0001.html>