D23918: RFC: Drop Outputs class

[Vlad Zahorodnii]

zzag added a comment.


  In D23918#530947 <https://phabricator.kde.org/D23918#530947>, @anthonyfieroni wrote:
  
  > You don't need virtual destructor when you don't have at least one virtual method, since you don't have at least one that method you don't want to delete object by its pointer to base. You use it to extend its functionality since that you declare objects by derived type, also you can add virtual destructor to derived class then extend with virtual methods and keep pointer to middle one.
  
  
  Um, I would say that's really bad code unless you use private inheritance.
  
  > There is nothing wrong with stl containers or any other class without virtual destructor without at a virtual method.
  >  https://onlinegdb.com/Bk9IKrc8S

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23918

To: zzag, #kwin
Cc: anthonyfieroni, romangg, davidedmundson, alexeymin, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190914/68c3670d/attachment.html>