D23913: [kcmkwin/kwineffects] Use new Kirigami ListSectionHeader component

Nathaniel Graham noreply at phabricator.kde.org
Thu Sep 12 19:12:12 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> Effect.qml:67
>  
> -            Kirigami.Heading {
>                  Layout.fillWidth: true

Are you sure about this change? Semantically, it is indeed a heading. If the purpose of this was to make the list item headings smaller than the section headers by using a Label, you can keep it as a Heading but raise the level to 5, which has the same size as a Label.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23913

To: GB_2, #kwin, #plasma, #vdg, davidedmundson
Cc: ngraham, kwin, #vdg, #plasma, #kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, gladhorn, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190912/ceca2f5a/attachment.html>


More information about the kwin mailing list