D23779: Make KWin action menu consistent with task manager, use action verbs for configure items and add more icons

TrickyRicky noreply at phabricator.kde.org
Sun Sep 8 11:32:54 BST 2019


trickyricky26 added inline comments.

INLINE COMMENTS

> useractions.cpp:291
>      m_noBorderOperation = advancedMenu->addAction(i18n("&No Border"));
> +    m_noBorderOperation->setIcon(QIcon::fromTheme(QStringLiteral("edit-none-border")));
>      setShortcut(m_noBorderOperation, QStringLiteral("Window No Border"));

If I'm not mistaken, this icon is currently not in the Breeze icon theme and is added in D23782 <https://phabricator.kde.org/D23782>. Not sure if this should have been used here already, but adding this comment for reference in D23782 <https://phabricator.kde.org/D23782>.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23779

To: GB_2, #kwin, #vdg, ndavis, davidedmundson
Cc: trickyricky26, davidedmundson, ndavis, #vdg, kwin, #kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190908/48a811a2/attachment.html>


More information about the kwin mailing list