D23779: Make KWin action menu consistent with task manager, use action verbs for configure items and add more icons

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Keeping them in sync makes sense. +++
  
  My comment applies to both here and taskmanager. I'd like you to have a brainstorm on that.

INLINE COMMENTS

> useractions.cpp:651
> +    m_menu->insertAction(m_maximizeOperation, action);
> +    action->setText(i18n("Move to &Activity"));
> +    action->setIcon(QIcon::fromTheme(QStringLiteral("activities")));

I don't like this one as the behaviour doesn't "move" the window.

REPOSITORY
  R108 KWin

BRANCH
  make-actions-context-menu-consistent-with-task-manager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23779

To: GB_2, #kwin, #vdg, ndavis, davidedmundson
Cc: davidedmundson, ndavis, #vdg, kwin, #kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190908/1493c897/attachment-0001.html>