D23669: Generate mipmaps for image down-scaling

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in scene_opengl.cpp:1495-1497
> Why do you think it should be vice versa?
> 
> Mipmaps are scaled down copies of a texture such that arbitrary down-scaling can be done quickly and without artifacts. That means the original must have been rendered already so it can be duplicated.
> 
> Maybe in the end it doesn't make a difference because it's a Gl command on the GPU.

You need to propagate updates from the base layer up to the maximum layer before mapping the texture. If this code were using mipmaps, you'd render a bit outdated contents.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23669

To: romangg, #kwin, zzag
Cc: zzag, davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190905/66a6e64c/attachment.html>