D23669: Generate mipmaps for image down-scaling

[Vlad Zagorodniy]

zzag requested changes to this revision.
zzag added a comment.
This revision now requires changes to proceed.


  One need to set a mipmapping minimification filter, like GL_LINEAR_MIPMAP_LINEAR, in order to actually use mipmaps.
  
  However, do we actually have to worry about noise level? I don't think so. GL_LINEAR should be more than enough.

INLINE COMMENTS

> scene_opengl.cpp:1495-1497
> +    if (filter = GL_LINEAR) {
> +        s_frameTexture->generateMipmaps();
> +    }

I don't understand this part. Window contents is rendered and after that mipmaps are generated. I think it should be vice versa.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23669

To: romangg, #kwin, zzag
Cc: zzag, davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190902/a0aae3aa/attachment.html>