D25022: Add some const &

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Oct 30 09:57:01 GMT 2019


zzag added a comment.


  In D25022#556508 <https://phabricator.kde.org/D25022#556508>, @aacid wrote:
  
  > What do you mean they are not movable?
  >
  >   https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qshareddata.h?h=5.13#n222
  
  
  Edit: "not all smart pointers in Qt are movable." :-)
  
  > has the move operator for QExplicitlySharedDataPointer which is what a KSharedConfigPtr is. It doesn't involve ref counting like the copy constructor in
  > 
  >   https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qshareddata.h?h=5.13#n185
  
  Yeah, but we also use QSharedPointer, which is not movable.

REPOSITORY
  R108 KWin

BRANCH
  arcpatch-D25022

REVISION DETAIL
  https://phabricator.kde.org/D25022

To: aacid, zzag
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191030/bbffb1ff/attachment-0001.html>


More information about the kwin mailing list