D25022: Add some const &

Albert Astals Cid noreply at phabricator.kde.org
Tue Oct 29 22:10:18 GMT 2019


aacid added inline comments.

INLINE COMMENTS

> zzag wrote in anidata.cpp:82-83
> Heh, the good old "should I pass a shared pointer by value or const reference?"
> 
> The reasoning why these are not passed by const ref is to express that AniData will share ownership of the locks.

fair enough, i'm now moving these ptrs instead of const &-ing them

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25022

To: aacid
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191029/c9989564/attachment.html>


More information about the kwin mailing list