D25022: Add some const &

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> anidata.cpp:82-83
>                   int delay, const FPx2 &from_, bool waitAtSource_,
> -                 FullScreenEffectLockPtr fullScreenEffectLock_, bool keepAlive,
> -                 PreviousWindowPixmapLockPtr previousWindowPixmapLock_)
>   : attribute(a)

Heh, the good old "should I pass a shared pointer by value or const reference?"

The reasoning why these are not passed by const ref is to express that AniData will share ownership of the locks.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25022

To: aacid
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191029/06774f60/attachment.html>