D24864: [effects] Add effect to hold the desktop window static after plasmashell quitsWhen a plasma session quits, the order of plasmashell and clients quittingis undetermined. This looks bad as our desktop background disappears quite early.Rather...

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> metadata.desktop:16
> +X-KDE-PluginInfo-EnabledByDefault=true
> +X-KDE-Ordering=40
> +X-Plasma-API=javascript

X-KWin-Internal=true

> kwineffects.h:831-832
> +    /**
> +     * The status of the session
> +     * i.e if the user is logging out
> +     */

The comment fits 100 characters limit, no need to break it.

> kwineffects.h:1378
> +    /**
> +     * @see Workspace::sessionState
> +     * @since 5.18

Please write more detailed description.

> kwinglobals.h:150
>  };
>  
> +Q_ENUM_NS(SessionState)

Matter of personal choice: I'd prefer to keep Q_ENUM_NS as close as possible to the enum, without introducing empty lines in between.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24864

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191022/d64e6c7c/attachment.html>