D24112: [platforms/drm] Disable transformations
Bhushan Shah
noreply at phabricator.kde.org
Sun Oct 13 19:02:17 BST 2019
bshah added a comment.
In D24112#546605 <https://phabricator.kde.org/D24112#546605>, @romangg wrote:
> In D24112#546346 <https://phabricator.kde.org/D24112#546346>, @bshah wrote:
>
> > @romangg Did you look into last comment? Commit 26cdfd317fc87b024ebcd9c2adefc86cfd59504e <https://phabricator.kde.org/R108:26cdfd317fc87b024ebcd9c2adefc86cfd59504e> was added to recover from the broken state of rotation/bad atomic commit. It seems that this code has regressed (atomic commit related code), we are not reverting back to correct plane (or output size), explicitly setting the correct mode using kscreen-doctor does recover from broken state/hang.
>
>
> Which comment?
https://phabricator.kde.org/D24112#538668
> The current fallback code on AMS is incorrect either way because we don't relay this information to KWayland output configuration. That's once again a larger project.
I am confused because this did work (even if code is fundamentally wrong maybe) at least during 5.16 release. Where if on my dell laptop I tried to rotate my screen to 90°, it would flick my screen but it would instantly then revert back to 0°. So clearly there's some regression somewhere, unfortunately not one which can be bisected.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D24112
To: romangg, #kwin
Cc: ngraham, jriddell, bshah, zzag, apol, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191013/7dd8a9ea/attachment-0001.html>
More information about the kwin
mailing list