D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom

[Cameron Rodgers]

cameronrodgers added a comment.


  In D23480#544775 <https://phabricator.kde.org/D23480#544775>, @ngraham wrote:
  
  > @cameronrodgers I think renaming the variable is OK. Please feel free to continue the work on this.
  
  
  I've been busy with schoolwork, but I did a bit more testing and I think it's pretty clear that blur is interacting with the title bars in a bad way.
  F7571049: Screenshot_20191011_012517.png <https://phabricator.kde.org/F7571049>
  As you can see in the pic, the color of the messed up title bar edges (and icons) reflects the color of the background image. Some are greenish, some white, blue, etc. 
  As well, the visual regression isn't a result of changing any of the highlight code (reverting the highlight stuff doesn't fix it in my patch). It's from moving the title bars over the edges of the windows, so that the blur effect on the edges takes in some of the wallpaper color. The problem is actually there in the code without this patch, it's just not very visible (if at all) because the title bars are centered on the windows.
  
  In D23480#538095 <https://phabricator.kde.org/D23480#538095>, @davidedmundson wrote:
  
  > FWIW, I intend to look into effect frames which will hopefully address this.
  
  
  EffectFrame is probably a good place to look for the source of the problem. I want to take a look at it, but it may be a bit beyond me.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23480

To: cameronrodgers, #kwin, #vdg, #plasma, ngraham
Cc: davidedmundson, ngraham, zzag, romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191011/05f34a86/attachment.html>