D24542: explicitly place fullscreen windows over fullscreen

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Oct 10 19:18:19 BST 2019


zzag added inline comments.

INLINE COMMENTS

> xdgshellclient.cpp:226
>      if (needsPlacement) {
> -        const QRect area = workspace()->clientArea(PlacementArea, Screens::self()->current(), desktop());
> -        placeIn(area);
> +        if (isFullScreen()) {
> +            setFrameGeometry(workspace()->clientArea(FullScreenArea, this));

Please do instead

  if (isFullScreen()) {
      needsPlacement = false;
  }

> xdgshellclient.cpp:1508-1510
> +    if (!isMaximizable()) {
> +        return;
> +    }

Looks like an unrelated change.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24542

To: mart, #kwin, #plasma
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191010/53c08c0e/attachment-0001.html>


More information about the kwin mailing list