D24461: Fix coding style issues in Scene::paintSimpleScreen

Vlad Zahorodnii noreply at phabricator.kde.org
Mon Oct 7 18:29:42 BST 2019


zzag added inline comments.

INLINE COMMENTS

> fredrik wrote in scene.cpp:258
> The comment here is lost.

Oops, fixed.

> fredrik wrote in scene.cpp:276
> Why the change to qobject_cast<>?

qobject_cast is considered to be a better choice because it's faster (I didn't benchmark it though) and doesn't need RTTI. However, in this case it is a leftover. Fixed.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24461

To: zzag, #kwin
Cc: fredrik, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191007/c1d8ca84/attachment.html>


More information about the kwin mailing list