D24461: Fix coding style issues in Scene::paintSimpleScreen

Fredrik Höglund noreply at phabricator.kde.org
Mon Oct 7 17:51:19 BST 2019


fredrik added inline comments.

INLINE COMMENTS

> scene.cpp:258
> -    bool opaqueFullscreen(false);
> -    for (int i = 0;  // do prePaintWindow bottom to top
> -            i < stacking_order.count();

The comment here is lost.

> scene.cpp:276
> +        if (window->isOpaque()) {
> +            AbstractClient *client = qobject_cast<AbstractClient *>(toplevel);
> +            if (client) {

Why the change to qobject_cast<>?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24461

To: zzag, #kwin
Cc: fredrik, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191007/02d83d23/attachment-0001.html>


More information about the kwin mailing list