D22571: Allow blacklisting some wayland interfaces

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Oct 7 11:38:26 BST 2019


apol added inline comments.

INLINE COMMENTS

> fvogt wrote in wayland_server.cpp:223
> AFAICT, "We're comparing a process with itself." is still the case.
> 
> It would need to compare the content of `client->executablePath()` with `/proc/pid/exe`, but even that can be faked easily.
> 
> Note that procfs is unusual - sha256("/proc/pid/exe") != sha256(readlink("/proc/pid/exe"))

No, what you wrote isn't what we are doing. We are going through /prog/pid/root/...
I don't really see how it would be faked for a remote process reliably.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22571

To: apol, #plasma, #kwin, davidedmundson
Cc: fvogt, zzag, broulik, graesslin, davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191007/2dbf9561/attachment.html>


More information about the kwin mailing list