D24328: [wayland] Process pending state and map the client on commit

[David Edmundson]

davidedmundson added a comment.


  Heh, I wasn't fully done reviewing this - there's some very big changes in the order events are processed which might have subtle nuances.
  My biggest concern was that we're now signalling damages before we've mapped the window, which is a bit weird.  Fortunately EffectsHandlerImpl::slotWindowDamaged has a guard already for some obscure teardown case and that seems to be the only user.
  
  This also somewhat goes against the API SurfaceInterface is trying to go for, which abstracts the double buffered API into a declarative set of properties. We're going to end up mixing two different styles as to whose responsibility it is to handle the atomic setting of everything.
  
  I see why you've done it, and using damage was awful, but I think we need to be careful.
  
  Anyway, reviewed now. Belated ship it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24328

To: zzag, #kwin
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191002/3d23a0a9/attachment.html>