D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used

Méven Car noreply at phabricator.kde.org
Thu Nov 21 14:14:35 GMT 2019


meven added a comment.


  > GLRenderTarget::virtualScreenScale() is currently only set to screen->scale during the paint method.
  
  I guess you are evoking in your comment scene_opengl.cpp:662.
  There for m_backend->perScreenRendering (wayland case) SceneOpenGL::paint() calls Scene::paintScreen() that then calls effects->postPaintScreen().
  I don't get how the static data at GLRenderTarget::virtualScreenScale are not available.
  I don't see where some other code might call postPaintScreen.
  I am missing something. If you could just point me to the right direction.
  
  >   This is postPaint. We could set it during pre/postPaint too.
  
  I'd like to understand how to make it available to the effects.
  I dug D8490 <https://phabricator.kde.org/D8490> and D4948 <https://phabricator.kde.org/D4948> for inspiration.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25427

To: meven, davidedmundson
Cc: davidre, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191121/eb654b3f/attachment.html>


More information about the kwin mailing list