D18000: Tweak slidingpopups effect to make animation smoother

Nathaniel Graham noreply at phabricator.kde.org
Mon Nov 18 16:35:38 GMT 2019


ngraham added a comment.


  @sefaeyeoglu thanks for this patch. We have a set of emerging guidelines for animations in D25343 <https://phabricator.kde.org/D25343>. Can you address the inline comments so we can push this forward?

INLINE COMMENTS

> slidingpopups.cpp:470
>      animation.timeLine.setDuration((*dataIt).slideInDuration);
> -    animation.timeLine.setEasingCurve(QEasingCurve::InOutSine);
> +    animation.timeLine.setEasingCurve(QEasingCurve::OutQuart);
>  

Let's make this `InQuad` to be consistent with most other animations in Plasma, and conform to the emerging guidelines in D25343 <https://phabricator.kde.org/D25343>.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18000

To: sefaeyeoglu, #vdg, zzag, #kwin
Cc: niccolove, ngraham, abetts, davidedmundson, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191118/a0673689/attachment.html>


More information about the kwin mailing list