D23114: [perf] Introduce ftrace marker

[Vlad Zahorodnii]

zzag added a comment.


  This still looks slightly over-engineered. You could put everything in one class and add a few convenience methods to make it a bit easier to use the new class.

INLINE COMMENTS

> ftrace_marker.h:1
> +/********************************************************************
> + KWin - the KDE window manager

I don't think that directory `helpers/` is the right place for the FtraceMarker class since it's not an internal utility. Directory `helpers/` contains libexec stuff.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23114

To: romangg, #kwin
Cc: davidedmundson, apol, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191118/9c526a83/attachment.html>