D24457: [wayland] Ensure that repaints_region is in frame-local coordinates

[David Edmundson]

davidedmundson added a comment.


  Let me try and explain my point again.
  
  In one invocation of TopLevel::addDamage the argument is relative to the buffer  (when we connect events from the wayland surface to here)
  In another invocation of TopLevel::addDamage the argument is relative to the frame  (when we're in the overridden implementation calling the base implementation)
  
  I am saying having one method defined where the argument semantics change depend on where it's called from is confusing.
  
  (That was the state before this patch too, I was just commenting on it whilst I saw it... )

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24457

To: zzag, #kwin, romangg
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191113/cbc75ed0/attachment-0001.html>