D25207: [libkwineffects] Construct correct mouse event when forwarding to QtQuickView

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Nov 13 17:59:46 GMT 2019


zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kwineffectquickview.cpp:206
> No specific reason. No compiler will complain about its presence either. 
> It's the same thing.

Okay, I see. Could you please drop these `Q_FALLTHOUGH` macros? There are a couple of reasons to do that:

(a) Putting `Q_FALLTHOUGH` or `[[fallthrough]]` in empty case blocks is uncommon
(b) It saves some vertical space

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25207

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191113/2115a2d3/attachment.html>


More information about the kwin mailing list